[lexical-core][code-node] Bug Fix: Adding an empty paragraph before code node #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
For the context: we have similar issue with QuoteNode (although selection there never jumps to the root node), so maybe we shall try to fix both :) Screen.Recording.2024-05-14.at.12.56.57.PM.mov |
StyleT
added
the
contribution-week
MaxPlav
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
MaxPlav
force-pushed
the
fix/code-block-focus-5968
branch
from
f678d85
to
0242803
Compare
MaxPlav
force-pushed
the
fix/code-block-focus-5968
branch
from
0242803
to
3699342
Compare
|
The issue is reproducible for other ElementNodes and should be fixed not only for the playground editor. Checked on ImageNode and it's possible to set the cursor before the node for adding a new element. |
MaxPlav
force-pushed
the
fix/code-block-focus-5968
branch
from
3699342
to
fdcf662
Compare
MaxPlav
changed the title
|
Discussed with @MaxPlav that more comprehensive solution needed here that accounts for more nodes and use cases (ex: two "column layout" nodes in the middle of the document) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an empty paragraph before a code node when a user clicks Arrow Up from the code block and there are no other nodes before the code node.
Closes: #5968
Test plan
Before
Screen.Recording.2024-05-14.at.11.27.26.mov
After
Screen.Recording.2024-05-16.at.11.38.59.mov