Update GenStrategy._make_default_name to avoid fitting models #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Summary: The current setup uses `node.model_spec_to_gen_from.model_key` to get the default name for a given node, which will attempt to fit models for GenNodes with multiple `model_spec`s. This diff avoids the `model_spec_to_gen_from` call for node-based GS and uses it only for step-based GS, where this is not an issue. Differential Revision: D56732974
saitcakmak
force-pushed
the
export-D56732974
branch
from
3b4d6b2
to
c28f500
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2412 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 495 495
Lines 48427 48429 +2
=======================================
+ Hits 46153 46155 +2
Misses 2274 2274 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The current setup uses
node.model_spec_to_gen_from.model_keyto get the default name for a given node, which will attempt to fit models for GenNodes with multiplemodel_specs. This diff avoids themodel_spec_to_gen_fromcall for node-based GS and uses it only for step-based GS, where this is not an issue.Differential Revision: D56732974