Validate paramter and metric names #2380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56316082 |
Summary: is_valid_name will be used for Metric and Paramter name validation. Constricting the values allowed will help with both parsing (as used in AxClient's constraints), plotting/report building, and more. Differential Revision: D56305954
Summary: Apply is_valid_name to all parameter and metric names Differential Revision: D56316082
mpolson64
force-pushed
the
export-D56316082
branch
from
be0d2ae
to
b743fe5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56316082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Apply is_valid_name to all parameter and metric names
Differential Revision: D56316082