Update datetime equality checks to use an absolute tolerance #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously, this would set microseconds to 0, effectively comparing that the events happened in the same second. If the seconds differed, even when the absolute difference was negligible, the checks would fail making some tests flaky. Updating the logic to rely on an absolute difference instead, with a default tolerance of 1e-2 seconds (which is sufficient to have existing, occassionally flaky tests pass). Differential Revision: D56077050
|
This pull request was exported from Phabricator. Differential Revision: D56077050 |
facebook-github-bot
added
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Previously, this would set microseconds to 0, effectively comparing that the events happened in the same second. If the seconds differed, even when the absolute difference was negligible, the checks would fail making some tests flaky. Updating the logic to rely on an absolute difference instead, with a default tolerance of 1e-2 seconds (which is sufficient to have existing, occassionally flaky tests pass).
Differential Revision: D56077050