Pull out mixin for setting X_pending in acquisition functions
#2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D55843962 |
facebook-github-bot
added
CLA Signed
Summary: X-link: facebookexternal/botorch_fb#19 X-link: pytorch/botorch#2287 Formerly, all subclasses of `Acquisition` had a method `set_X_pending`, even if they did not support pending points. This confused me while writing tests for optimizing acquisition functions. - Pulled out a mixin `XPendingMixin` so that classes only have the method `set_X_pending` where it is functional and appropriate - Removed "UnsupportedError" overrides from classes that no longer have a `set_X_pending` method - Clarified which classes are supported in `optimize_acqf` and similar functions; added more precise type hints. Differential Revision: D55843962
esantorella
force-pushed
the
export-D55843962
branch
from
68bdd55
to
1a8851c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55843962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Formerly, all subclasses of
Acquisitionhad a methodset_X_pending, even if they did not support pending points. This confused me while writing tests for optimizing acquisition functions.XPendingMixinso that classes only have the methodset_X_pendingwhere it is functional and appropriateset_X_pendingmethodoptimize_acqfand similar functions; added more precise type hints.Differential Revision: D55843962