Adding DeprecatedTransformMixin class #2321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This task starts the backlog task T182722751 "Rename Ax transforms in terms of what they transform from and to, when it isn't clear" It has a list of transforms to have their names updated to clearer values ``` OrderedChoiceEncode -> OrderedChoiceToIntegerRange ChoiceEncode -> ChoiceToNumericChoice TaskEncode -> TaskChoiceToIntTaskChoice Cast -> Map ``` This change - Adds a "DeprecatedTransformMixin", which classes can inherit from in order to print a logging message with the deprecated transform and the new transform to update to. - Overrides the __eq__ built-in of Transform to support equality between a DeprecatedTransform(DeprecatedTransformMixin, Transform) and an equivalent Transform object. This is needed for cases where a DeprecatedTransform is saved to a sqa store, and loaded back as the equivalent renamed Transform Subsequent changes will add the new transform classes, and update the transform registry to point to the new classes instead of the old. ## Warning The warning is as follows: ``` [WARNING 04-04 09:58:45] ax.modelbridge.transforms.deprecated_transform_mixin: `DeprecatedTransform` transform has been deprecated and will be removed in a future release. Using `Transform` instead. ``` Differential Revision: D55643016
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55643016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This task starts the backlog task T182722751 "Rename Ax transforms in terms of what they transform from and to, when it isn't clear"
It has a list of transforms to have their names updated to clearer values
This change
Subsequent changes will add the new transform classes, and update the transform registry to point to the new classes instead of the old.
Warning
The warning is as follows:
Differential Revision: D55643016