use workspace for local packages #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solarsoft0
changed the title
eykrehbein
approved these changes
Jul 11, 2023
|
@solarsoft0 Thanks for bringing this up! Looks good! What exact issue did you face regarding the npm types? |
on looking at the files in node_modules i noticed the release is not built. https://www.npmjs.com/package/@usefoundry/foundry?activeTab=code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon investigating, I am uncertain whether this change will fix the incorrect types being built in the npm packages. I attempted to recreate the issue after cloning the repository, but was unsuccessful. However, when i first attempted to install this package from npm into a new project, it consistently results in type errors.
Regardless of the issue at hand, this PR introduces updates to the local packages used, aligning them with the pnpm convention for working with workspaces.