[build-properties] Add field to enable/disable privacy manifest aggregation #28646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
requested review from
EvanBacon,
aleqsio,
Kudo and
gabrieldonadel
as code owners
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
brentvatne
commented
May 6, 2024
| const { modResults: iosModResultsEnabled } = await compileMockModWithResultsAsync( | ||
| {}, | ||
| { | ||
| plugin: withBuildProperties, | ||
| pluginProps: { ios: { ccache: true } }, | ||
| pluginProps: { ios: { ccacheEnabled: true } }, |
There was a problem hiding this comment.
this test looked incorrect, typechecking was failing on it
brentvatne
requested review from
keith-kurak
and removed request for
Kudo,
Simek,
EvanBacon,
amandeepmittal and
gabrieldonadel
This was referenced May 8, 2024
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There are a few issues right now with privacy manifest aggregation (facebook/react-native#44410, facebook/react-native#44402, facebook/react-native#44402) that I expect will be fixed in React Native 0.74.2, but in order to ensure that this doesn't break builds I've disabled it by default and added this build property to allow folks to toggle it on. We can switch on by default when 0.74.2 is released and proven to handle some edge cases better.
How
Same old process for adding a new property
Test Plan
Run tests
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).