Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't update locked items #7861

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

therealrinku
Copy link
Contributor

Don't allow editing of locked items
Issue: #7831

Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Apr 6, 2024 10:40am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Apr 6, 2024 10:40am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Apr 6, 2024 10:40am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 6, 2024 10:40am

@ryan-di
Copy link
Member

ryan-di commented Apr 8, 2024

@therealrinku thanks for the fix! Great work :)

In addition to the extra check that's been added, perhaps, we shouldn't be showing the properties panel at all when a locked element is selected via right clicks. What do you reckon, @dwelle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants