Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ manage the flow of errors through results instead of relying on exceptions. #124

Merged
merged 20 commits into from
May 24, 2024
Merged

✨ manage the flow of errors through results instead of relying on exceptions. #124

merged 20 commits into from
May 24, 2024

Conversation

kamilbaczek
Copy link
Collaborator

@kamilbaczek kamilbaczek commented Apr 15, 2024 •
edited

PR includes ✨

  • Refactor business rules and validators to use results instead of exceptions
  • Manage the flow of errors through results instead of relying on exceptions
  • Rename tests match to errors instead of exceptions
  • Refactor endpoints and commands

PR does not include ❌

  • Extracting business rule validators to a NuGet package

@kamilbaczek kamilbaczek changed the title Manage the flow of errors through resul instead of relying exceptions manage the flow of errors through result instead of relying exceptions Apr 15, 2024
@kamilbaczek kamilbaczek marked this pull request as ready for review May 8, 2024 17:05
@kamilbaczek kamilbaczek changed the title manage the flow of errors through result instead of relying exceptions ✨ manage the flow of errors through results instead of relying on exceptions. May 11, 2024
meaboutsoftware
meaboutsoftware requested changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@meaboutsoftware meaboutsoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. It looks great! So similar to promises, I really like that approach. It is cool that it evolved to such form in comparison to the draft that we discussed previously :)
  2. You can move all the common logic to common package that we have for chapter 4 in a separate branch - it would be just great to do it ASAP as this one is merged.
  3. Some formatting issues.

Absolutely fantastic job!

...main-driven-design/Fitnet.Contracts/Src/Fitnet.Contracts.Api/Common/Errors/ProblemResults.cs Outdated Show resolved Hide resolved
...et.Contracts.Application/AttachAnnexToBindingContract/AttachAnnexToBindingContractCommand.cs Outdated Show resolved Hide resolved
...Fitnet.Contracts/Src/Fitnet.Contracts.Application/SignContract/SignContractCommandHandler.cs Show resolved Hide resolved
...Contracts/Src/Fitnet.Contracts.Core.UnitTests/Common/Assertions/ErrorOr/ErrorOrAssertions.cs Show resolved Hide resolved
...Contracts/Src/Fitnet.Contracts.Core.UnitTests/Common/Assertions/ErrorOr/ErrorOrAssertions.cs Show resolved Hide resolved
...Contracts/Src/Fitnet.Contracts.Core.UnitTests/Common/Assertions/ErrorOr/ErrorOrAssertions.cs Outdated Show resolved Hide resolved
.../Fitnet.Contracts/Src/Fitnet.Contracts.Core.UnitTests/Fitnet.Contracts.Core.UnitTests.csproj Outdated Show resolved Hide resolved
...esign/Fitnet.Contracts/Src/Fitnet.Contracts.Core.UnitTests/SignContract/SignContractTests.cs Show resolved Hide resolved
...en-design/Fitnet.Contracts/Src/Fitnet.Contracts.Core/Common/BussinessRules/BusinessErrors.cs Outdated Show resolved Hide resolved
...gn/Fitnet.Contracts/Src/Fitnet.Contracts.Core/Common/BussinessRules/BusinessRuleValidator.cs Show resolved Hide resolved
@kamilbaczek kamilbaczek linked an issue May 18, 2024 that may be closed by this pull request
Domain Error Flow is controlled by exceptions that has impact on performance and maintability - We can switch to discriminated union results #116
Closed
@kamilbaczek
feat: Add BusinessRuleValidator class and update Contract class to us…
da96fd9 
…e ErrorOr type
@kamilbaczek
refactor: ICommand interfaces to use ErrorOr type for command results
ea545aa
@kamilbaczek
feat: implement error or in app
410c32b
@kamilbaczek
refactor: SignContractBuilder and SignContractTests to use the Value …
4bd1531 
…property of the returned bindingContract
@kamilbaczek
fix: validation error descriptions
542932d
@kamilbaczek
refactor: apply error of pattern
6ac35ae
@kamilbaczek
feat: use error or insted exceptions
4f0753e
@kamilbaczek
feat: implement error or for all business rules
9796677
@kamilbaczek
fix: adjust integration tests to result flow control
be179c0
@kamilbaczek
refactor: add assertions for error or
22f898a
@kamilbaczek
refactor: use bussiness error error insted native one
45cbfd0
@kamilbaczek
fix: adjust binding contracts actions to results
cc66750
@kamilbaczek
refactor: extract error or to global usings
2fed2aa
@kamilbaczek
fix: return more errors if possible
6f3f20b
@kamilbaczek
feat: add error or for get contract
31137f2
@kamilbaczek kamilbaczek merged commit e8f636c into main May 24, 2024
2 checks passed
@kamilbaczek kamilbaczek deleted the feature/error_handler branch May 24, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meaboutsoftware meaboutsoftware meaboutsoftware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kamilbaczek @meaboutsoftware