Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update systemd service file #310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deathtrip
Copy link
Contributor

It's better to let directory creation be handled by packaging, instead of executing it on every daemon start. On Arch Linux for example, that directory is already contained in the package.
When that line is removed PermissionsStartOnly=true can go as well, it's deprecated anyway.

It's better to let directory creation be handled by packaging, instead of executing it on every daemon start. On Arch Linux that directory is already contained in the package.
When that line is removed `PermissionsStartOnly=true` can go as well, it's [deprecated](systemd/systemd#10802) anyway.
@tianon
Copy link

tianon commented Dec 21, 2020

FWIW, this should be doable in Debian packaging too most easily/directly via debian/<package>.dirs: https://manpages.debian.org/buster/debhelper/dh_installdirs.1.en.html

(I had a similar "huh, that's interesting" moment while reviewing this service file recently 😄)

@gustavo-iniguez-goya
Copy link
Collaborator

The PR can not be accepted as is, because we'd break non-arch installations.

I think that this task should be done from the daemon, otherwise we'll depend on the service manager used by the distro (systemd, sysv, s6, openrc, etc, etc)

@deathtrip
Copy link
Contributor Author

I don't think removing these lines would break opensnitch. As right now on non-systemd distros, the rules directory still has to be created some other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants