Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EdgeTech Smart EVSE #13946

Merged
merged 11 commits into from
May 27, 2024
Merged

Add EdgeTech Smart EVSE #13946

merged 11 commits into from
May 27, 2024

Conversation

premultiply
Copy link
Member

Replaces #13852

@premultiply premultiply added the devices Specific device support label May 17, 2024
@premultiply premultiply self-assigned this May 17, 2024
charger/smartevse.go Outdated Show resolved Hide resolved
charger/smartevse.go Outdated Show resolved Hide resolved
charger/smartevse.go Show resolved Hide resolved
@andig
Copy link
Member

andig commented May 19, 2024

@premultiply was fehlt noch?

premultiply and others added 4 commits May 19, 2024 13:25
Co-authored-by: andig <andi@evcc.io>
@premultiply premultiply marked this pull request as ready for review May 19, 2024 13:03
@andig
Copy link
Member

andig commented May 19, 2024

@swallage ok?

@swallage
Copy link

All check passed, great! Should I check out the unstable branch to verify?

@andig
Copy link
Member

andig commented May 24, 2024

@swallage please check out this PR for testing! If not possible we could merge as-is and you can test in nightly.

@swallage
Copy link

I just started to test it. It seems however that the features
cphwonlock: true/false
cpwakeauto: true/false
are not supported in this version.

@swallage
Copy link

@andig : at the moment the board only supports a hardware lock (that locks the plug) or a CP-disconnects requires additional hardware. So when the features cphwonlock and cpwakeauto are not available that is fine. The line 243-246 is a different issue. Let me check

@swallage
Copy link

Your suggestion seems better as it avoids specifying the value at different places. As I am not a Go-expert, this double check:
settings |= 1 // set bit 0 (smartEVSEConfPhases)
is the same as
settings |= 0x1
?

@andig

This comment was marked as outdated.

@premultiply
Copy link
Member Author

Yes, it is the same.

@premultiply
Copy link
Member Author

premultiply commented May 27, 2024

I just started to test it. It seems however that the features
cphwonlock: true/false
cpwakeauto: true/false
are not supported in this version.

If the hardware supports wake-up it always should handle it by itself.
Looks to me that this may only require a firmware update?

So there is no need to do any special handling by evcc or special config vars to be set by the user.

Hint: Maybe you can alter the firmware to skip the crude and not recommended relais solution on CP line at all and provide just the -12V on CP by EVSE for wake-up assist function as defined by EV40.

“E.V. READY” CERTIFICATION TECHNICAL REFERENCE DOCUMENT
Version 2.0

EV40:
After a starting sequence, if the car does not close its S2 switch within 30 s after the B2 state, the station will simulate a disconnection of cable on
station side during 4 to 10 s and will restart the charging sequence with a B1 state. The station shall wait longer than 0,5 s and lower than 1 s before
entering X2 state (X2 means B2 or C2).
In case the car turns to C1 state during B1 state, the station should supply energy within 2 s max after beginning of C2 state.
Purpose of this sequence is to wake up a possible car asleep. This will be applied only once.

grafik

@swallage
Copy link

Cool @premultiply , thanks a lot. We were not that happy with the CP-disconnect using a relay.

@swallage
Copy link

swallage commented May 27, 2024

I just started to test it. It seems however that the features cphwonlock: true/false cpwakeauto: true/false are not supported in this version.

@premultiply : see the issue #13946 (comment) above. Not sure what happened with the cphwonlock feature (requires additional hardware, but feature was in original PR).

@swallage
Copy link

Perhaps @andig removed the HW-lock feature. For me that is fine for now. We have to look at CP disconnect again after the suggestion of @premultiply . Is the PR good enough to merge into the main tree?

@premultiply
Copy link
Member Author

Not sure what happened with the cphwonlock feature (requires additional hardware, but feature was in original PR).

I removed it as if it exists it should be handled by EVSE itself without any configuration needs on evcc side.
Seems to have an "automatic" mode from what I understand about it.

@swallage
Copy link

So cool, does that mean the charger will be merged?

@premultiply premultiply merged commit 1ec610d into master May 27, 2024
6 checks passed
@premultiply premultiply deleted the device/smartevse branch May 27, 2024 13:00
@swallage
Copy link

😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants