Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DHT reading timing for SI7021 on ESP32 #6604

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

erdembey
Copy link

Implementation of Benoit Goudy, which is still working on latest esphome.

Based on timing from tasmota sources

What does this implement/fix?

There is still sensor reading problems with existing implementation of SI7021 in dht.
It was solved by @Beungoud but not imported in existing code base.
I've tried with latest esphome and its working as intended.
Sonoff THR320 and THR316 with THS01 Sensor is effected.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

This issue is discussed in these issue topics;
4241
4189

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

sensor:
  - platform: dht
    pin: GPIO25
    model: SI7021
    temperature:
      name: "${friendly_name} Temp"
      id: "${name}_temp"
      filters:
        - filter_out: nan
    humidity:
      name: "${friendly_name} Humi"
      id: "${name}_humi"
      filters:
        - filter_out: nan
    update_interval: 5min

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Implementation of Benoit Goudy, which is still working on latest esphome.
@probot-esphome
Copy link

Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration (dht) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.43%. Comparing base (4d8b5ed) to head (eff6a15).
Report is 424 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6604      +/-   ##
==========================================
- Coverage   53.70%   53.43%   -0.28%     
==========================================
  Files          50       50              
  Lines        9408     9537     +129     
  Branches     1654     1685      +31     
==========================================
+ Hits         5053     5096      +43     
- Misses       4056     4130      +74     
- Partials      299      311      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants