New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humidifier component #6591
Humidifier component #6591
Conversation
Hey there @Jaco1990, CODEOWNERS = ["@Jaco1990"] And run (message by NeedsCodeownersLabel) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6591 +/- ##
==========================================
+ Coverage 53.70% 54.12% +0.41%
==========================================
Files 50 50
Lines 9408 9583 +175
Branches 1654 1687 +33
==========================================
+ Hits 5053 5187 +134
- Misses 4056 4070 +14
- Partials 299 326 +27 ☔ View full report in Codecov by Sentry. |
Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration ( |
I'm very interested :) Thanks so much! Not sure if you're aware, but there was an earlier attempt that was almost there but kind of died down:
Hopefully this one gets merged! |
Another thing: I'm personally interested in a dehumidifier. Home Assistant calls the component a "humidifier", but I believe it supports both. Moreover, the "generic" component is a called a "generic hydrostat", rather than a "generic humidifier". Perhaps this should follow suit? That said, given what happened with the earlier attempt at this, I'd personally rather see this merged as-is and later iterated on, rather than attempting to make it support all use cases. |
I hope it gets merged as well. once there is a proper UI to test from ill be happy to put in more work. I have seen the Generic Hygrostat. and I would love to get the component working for dehumidifiers as well. At the moment I do not own a Dehumidifier to test the component with and where I stay we are moving into our dry season, I might be able to get a dehumidifier later this year. |
…phome#6576) Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Hey there @latonita, @martgras, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @latonita, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @latonita, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @latonita, mind taking a look at this pull request as it has been labeled with an integration ( |
I have one, and I can play around with hooking it up! It's a Tuya one, so I can use the generic hydrostat to begin with, but in the longer I'll try to hook up the Tuya component directly (similar to Tuya Climate etc.). But let's not get ahead of ourselves :) BTW I noticed this PR was just closed? Was this accidental? |
I closed it because my commit went haywire. I will submit another pull request. I just need to work out the issues. |
What does this implement/fix?
Add a humidifier component to ESPHome as well as Generic Humidifier (User Modifiable) component similar to Bang Bang in climate.
Types of changes
Related issue or feature (if applicable): N/A
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3808
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: