Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data dashboard - data_loader.py #1526

Merged
merged 2 commits into from
May 20, 2024

Conversation

yongzheJIN
Copy link
Contributor

@yongzheJIN yongzheJIN commented May 16, 2024

fix always use the first column as row Name+handle value None and no data
We cannot use try Catch to ignore the ERROR.

Description

To organize the data for data dashboard. To just regard the first column as name is pretty rude. I find a method that will meet no errors(while the sql get from GPT is right). It can handle if there are no data in mysql database or there are all None data in mysql database.

How Has This Been Tested?

Even the data in the mysql database is None is still ok.

Snapshots:

image

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

fix always use the first column as row Name+handle value None and no data
@csunny
Copy link
Collaborator

csunny commented May 17, 2024

Thanks for your pr, please fix the format error, use make fmt @yongzheJIN

use make fmt to format data_loaderpy
@yongzheJIN
Copy link
Contributor Author

Thanks for your pr, please fix the format error, use make fmt @yongzheJIN

I have use make fmt to format the file. the makefile actually is not work in windows 10. I have make some changes about it. list as following"

  1. touch->echo
  2. bin/activate>Scripts/activate
    "

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Collaborator

@yhjun1026 yhjun1026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit d9a60f9 into eosphoros-ai:main May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants