basic_auth: add WWW-Authenticate header for 401 response #34214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sdwbgn, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
/retest |
wbpcode
reviewed
May 18, 2024
Comment on lines
103
to
109
| decoder_callbacks_->sendLocalReply( | ||
| Http::Code::Unauthorized, body, | ||
| [uri = this->original_uri_](Http::ResponseHeaderMap& headers) { | ||
| std::string value = absl::StrCat("Basic realm=\"", uri, "\""); | ||
| headers.setCopy(Http::Headers::get().WWWAuthenticate, value); | ||
| }, | ||
| absl::nullopt, response_code_details); |
There was a problem hiding this comment.
Thanks for the contribution. LGTM overall.
But I don't think we need to create and store the original_uri_ as a member of filter. You could simply capture this in the lambda and build the value in the lambda.
Tips: You can get request headers by the decoder_callbacks_->requestHeaders() in the lambda.
|
/wait |
Signed-off-by: Vasilii Bulatov <sdwbgn@gmail.com>
Signed-off-by: Vasilii Bulatov <sdwbgn@gmail.com>
Signed-off-by: Vasilii Bulatov <sdwbgn@gmail.com>
Signed-off-by: Vasilii Bulatov <sdwbgn@gmail.com>
sdwbgn
force-pushed
the
add_realm_for_basic_auth
branch
from
6fa48d8
to
be5a3e0
Compare
Signed-off-by: Vasilii Bulatov <sdwbgn@gmail.com>
sdwbgn
force-pushed
the
add_realm_for_basic_auth
branch
from
828c929
to
21fb89d
Compare
|
/retest |
wbpcode
reviewed
May 28, 2024
| const auto request_headers = this->decoder_callbacks_->requestHeaders(); | ||
| const std::string uri = Http::Utility::buildOriginalUri(*request_headers, MaximumUriLength); | ||
| const std::string value = absl::StrCat("Basic realm=\"", uri, "\""); | ||
| headers.setCopy(Http::Headers::get().WWWAuthenticate, value); |
Signed-off-by: Vasilii Bulatov <sdwbgn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Adds valid WWW-Authenticate header for 401 response in Basic Auth filter
Additional Description:
Risk Level: Low
Testing: unit test, integration
Docs Changes: N/A
Release Notes: Set
WWW-Authenticateheader for 401 responses from the Basic Auth filter.Platform Specific Features: N/A
Fixes #34015