Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds: changing to factory instantiation #34203

Merged
merged 1 commit into from
Jun 3, 2024
Merged

rds: changing to factory instantiation #34203

merged 1 commit into from
Jun 3, 2024

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented May 16, 2024 •
edited

Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176

@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34203 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk force-pushed the rds4 branch 6 times, most recently from 3d4d35e to 7b8aadc Compare May 22, 2024 18:55
@alyssawilk
rds: changing to factory instantiation
c75b630 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Contributor Author

/retest

@alyssawilk alyssawilk marked this pull request as ready for review May 29, 2024 12:38
adisuissa
adisuissa approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alyssawilk alyssawilk merged commit 84653b1 into envoyproxy:main Jun 3, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuercher zuercher zuercher approved these changes

@adisuissa adisuissa adisuissa approved these changes

@RyanTheOptimist RyanTheOptimist Awaiting requested review from RyanTheOptimist RyanTheOptimist is a code owner

@abeyad abeyad Awaiting requested review from abeyad abeyad is a code owner

@fredyw fredyw Awaiting requested review from fredyw fredyw is a code owner

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

Assignees

@zuercher zuercher

@adisuissa adisuissa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssawilk @zuercher @adisuissa