Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accesslog: add %TRACE_ID% formatter #34198

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

zirain
Copy link
Contributor

@zirain zirain commented May 16, 2024

Commit Message: for #34102, add %TRACE_ID% accesslog formatter.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #34102
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Copy link
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

test/common/formatter/substitution_formatter_test.cc Outdated Show resolved Hide resolved
source/common/formatter/http_specific_formatter.cc Outdated Show resolved Hide resolved
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from zuercher May 17, 2024 03:37
@zirain
Copy link
Contributor Author

zirain commented May 21, 2024

kindly ping @zuercher

Copy link
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zuercher zuercher merged commit c28f01c into envoyproxy:main May 23, 2024
53 checks passed
@zirain zirain deleted the traceid-formatter branch May 23, 2024 00:37
cancecen pushed a commit to cancecen/envoy that referenced this pull request May 23, 2024
Risk Level: low
Testing: unit test
Docs Changes: formatter documented
Release Notes: add
Fixes envoyproxy#34102
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: Can Cecen <ccecen@netflix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants