Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix exit code check in corpus_from_config_impl helper script #34178

Merged
merged 1 commit into from
May 17, 2024

Conversation

tedjpoole
Copy link
Contributor

If the config_impl_test_static executable exited with a non-zero exit code, the output text and the log message were not being printed as expected, thus obscuring the failure reason.

If the config_impl_test_static executable exits with a non-zero exit
code, its output text and log message were not being printed as expected.

Signed-off-by: Ted Poole <tpoole@redhat.com>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @tedjpoole

@phlax phlax merged commit e1c31c3 into envoyproxy:main May 17, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants