Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow file/read to return the contents of a collaborative buffer #9994

Merged
merged 1 commit into from
May 20, 2024
Merged

Allow file/read to return the contents of a collaborative buffer #9994

merged 1 commit into from
May 20, 2024

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented May 17, 2024 •
edited

Pull Request Description

part of #9960

Changelog:

  • feat: file/read return contents of a collaborative buffer if they are available and fallback to reading the file from disk

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label May 17, 2024
@4e6 4e6 self-assigned this May 17, 2024
JaroslavTulach
JaroslavTulach approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test has been written and looks sane.

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label May 20, 2024
@mergify mergify bot merged commit 643b66d into develop May 20, 2024
38 checks passed
@mergify mergify bot deleted the wip/db/9960-refactor-does-not-update-buffer-1 branch May 20, 2024 14:02
@4e6 4e6 mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@4e6 4e6

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@4e6 @JaroslavTulach