Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test framework to default to only show failures #9986

Merged

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented May 17, 2024

Pull Request Description

This change removes the environment variable REPORT_ONLY_FAILED and makes that the default behavior. (With an additional change that pending tests are also always printed)
It adds a new environment variable REPORT_ALL_TESTS which when set gives you the old behaviour.

image

Closes #9729

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label May 17, 2024
@AdRiley AdRiley marked this pull request as ready for review May 17, 2024 15:27
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Printing only problematic tests is a nice way to see the important summary.

Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like that the report is more consistent with the report of jUnit - that also prints only failures by default.

@AdRiley AdRiley merged commit 3b59b40 into develop May 21, 2024
35 of 36 checks passed
@AdRiley AdRiley deleted the wip/adr-make-test-framework-only-display-failures-as-default branch May 21, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve how Test failures are summarized
5 participants