Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to browser for user registration #10000

Merged
merged 2 commits into from
May 23, 2024

Conversation

somebody1234
Copy link
Collaborator

Pull Request Description

Important Notes

None

Testing Recommendations

  • Just test on both the desktop app, and Cloud, that the registration flow works as expected.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. x-new-feature Type: new feature request g-dashboard labels May 20, 2024
@MrFlashAccount
Copy link
Contributor

QA ✅

@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label May 20, 2024
@somebody1234
Copy link
Collaborator Author

ah i guess the test CI fail is due to:

@MrFlashAccount
Copy link
Contributor

10000's PR 🔥

@mergify mergify bot merged commit d4ef04b into develop May 23, 2024
35 checks passed
@mergify mergify bot deleted the wip/sb/register-in-browser-only branch May 23, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants