-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(events): Allow explicit 0 for events to apply directly #10054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested changing map and player swizzle; normal events still work as they should.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The single comment in this PR looks grammatically perfect.
Thank you so much :)
literally the easiest way and performance in panels is not a bottleneck anyways
Works as expected with the Hai Start PR. |
Feature
This PR addresses the bug/feature described in issue #6719 and as requested by @bene-dictator
Summary
Up til now events were only applied on the next increment of date. This PR allows for an explicit time to event of 0, which mean the event gets applied when the game action is triggered.
Take this example:
The map changes will be seen as soon as the mission gets accepted
Testing Done
I used the test mission to test it once with explicit 0 and without, worked like expected, with explicit 0 map changes were seen directly, without I had to depart
Performance Impact
N/A
Side Note
I looked through the data files and there is no place where event gets used with a 0, so no need to change anything there.