-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin): serde not found on new-joined nodes #13063
Merged
HJianBo
merged 15 commits into
emqx:release-57
from
JimMoen:improve-plugin-config-behavior
May 23, 2024
Merged
fix(plugin): serde not found on new-joined nodes #13063
HJianBo
merged 15 commits into
emqx:release-57
from
JimMoen:improve-plugin-config-behavior
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongwencool
requested changes
May 17, 2024
JimMoen
force-pushed
the
improve-plugin-config-behavior
branch
2 times, most recently
from
May 21, 2024 09:41
c79848d
to
3660cbb
Compare
JimMoen
force-pushed
the
improve-plugin-config-behavior
branch
from
May 21, 2024 18:20
3660cbb
to
5abd23a
Compare
JimMoen
force-pushed
the
improve-plugin-config-behavior
branch
from
May 21, 2024 22:03
43a2720
to
14f2a68
Compare
HJianBo
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhongwencool
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-12349 EMQX-12350
Release version: v/e5.7.0
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
[ ] Added tests for the changes[ ] Added property-based tests for code which performs user input validation[ ] Changed lines covered in coverage report[ ] Change log has been added tochanges/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md
files[ ] Schema changes are backward compatibleChecklist for CI (.github/workflows) changes
[ ] If changed package build workflow, pass this action (manual trigger)[ ] Change log has been added tochanges/
dir for user-facing artifacts update