fix(sessds): Rename last_alive_update_interval -> heartbeat_interval #13062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieQu1
force-pushed
the
dev/ds-better-naming
branch
from
8076d97
to
6f30c1c
Compare
keynslug
approved these changes
May 17, 2024
| sc( | ||
| timeout_duration(), | ||
| #{ | ||
| default => <<"5000ms">>, | ||
| desc => ?DESC(session_ds_last_alive_update_interval) | ||
| desc => ?DESC(session_ds_heartbeat_interval) |
There was a problem hiding this comment.
I wonder why spellcheck does not say anything about this being undefined in the respective emqx_schema.hocon.
There was a problem hiding this comment.
I think this is because this parameter is hidden.
I'll make a change to unhide later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-12398
Release version: v/e5.?
Summary
Rename configuration parameter
durable_sessions.last_alive_update_intervaltodurable_sessions.heartbeat_intervalPR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update