feat(s3-bridge): meld 2 separate actions into a single one #13059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
previously approved these changes
May 16, 2024
| desc => ?DESC(s3_aggregated_upload_mode) | ||
| } | ||
| )}, | ||
| {container, |
There was a problem hiding this comment.
A small suggestion, since this belongs to the new app (I noticed this after the last PR 😅 ): thalesmg@a9244cb
There was a problem hiding this comment.
Good point, but this commit is still part of unmerged PR, or am I missing something? What do you think if we merge this one as is to unblock the dashboard team sooner?
keynslug
force-pushed
the
feat/EMQX-12204/single-action-schema
branch
from
666e881
to
82326c3
Compare
Discriminated through `mode` parameter. Also rename "simple" action to a "direct" upload mode.
keynslug
force-pushed
the
feat/EMQX-12204/single-action-schema
branch
from
82326c3
to
39c2433
Compare
zmstone
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-12204.
Release version: e5.7
Summary
Discriminated through
modeparameter. Also rename "simple" action to a "direct" upload mode.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Added property-based tests for code which performs user input validationchanges/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles