Fix small action trace issues #13053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing non-batch inserts with the MySQL action, prepared statements are used. We therefore need to include the parameters to the prepared statement when tracing the rendered templates. Fixes: https://emqx.atlassian.net/browse/EMQX-12335
kjellwinblad
force-pushed
the
kjell/fix_rule_trace_issues/EMQX-12327/EMQX-12335/EMQX-12336
branch
from
cd909fa
to
413ad60
Compare
zmstone
reviewed
May 16, 2024
zmstone
previously approved these changes
May 16, 2024
ieQu1
previously approved these changes
May 16, 2024
kjellwinblad
force-pushed
the
kjell/fix_rule_trace_issues/EMQX-12327/EMQX-12335/EMQX-12336
branch
2 times, most recently
from
c440029
to
2209b26
Compare
This commit renames trace fields rule_trigger_time and rule_trigger_times to rule_trigger_ts and makes sure that the value for rule_trigger_ts will always be a list of timestamps.
zmstone
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes fixes for two small action trace issues:
Fixes:
https://emqx.atlassian.net/browse/EMQX-12336
https://emqx.atlassian.net/browse/EMQX-12335
Release version: v/e5.?
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles