feat(channel): handle multiple subscribes partially in parallel #12280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynslug
force-pushed
the
fix/EMQX-11483/multi-sub
branch
from
64844ce
to
0158d08
Compare
Also make sure that broken hook implementations won't cause unrelated crashes down the line.
That returns as soon as the local state have been updated (but not the global state, i.e. routing).
Namely, when they are part of a single SUBSCRIBE packet.
keynslug
force-pushed
the
fix/EMQX-11483/multi-sub
branch
from
37f375d
to
0448173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-11483.
Release version: v5.5
Summary
If a
SUBSCRIBEpacket from the Client contains multiple subscriptions EMQX will now attempt to process them in parallel, at lest partially. More precisely: as before, Client will get a reply once the cluster (well, the set of core nodes) knows about new subscriptions, but the propagation of routing table updates per each new subscription will now happen concurrently if possible, i.e. when thebatch_syncis enabled.Currently includes #12237, will be rebased once it's merged.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Added property-based tests for code which performs user input validationchanges/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesCreated PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket