Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Obs SLOs][KEYBOARD]: Actions menu must be available in Card view on ::focus event #183652

Merged
merged 4 commits into from
May 20, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 16, 2024

Closes: https://github.com/elastic/observability-dev/issues/3390

Description

The Obs SLOs cards allow users to access a menu of actions on ::hover but that menu is not available on ::focus. This has a workaround by switching to List or Compact view, but still represents a major keyboard usability issue and is going to be treated as a level one defect. Screenshot attached below.

Steps to recreate

  1. Open the Obs SLOs view
  2. Create a new SLO if none exist
  3. Hover over the newly created SLO card and verify the [ ... ] menu appears
  4. Now press the Tab key to navigate through the card by keyboard
  5. Verify the [ ... ] menu never appears

What was changed?:

1 The hover functionality was updated in favor of CSS

Screen

Screen.Recording.2024-05-16.at.17.31.13.mov

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 Project:Accessibility Feature:SLO labels May 16, 2024
@alexwizp
Copy link
Contributor Author

/ci

@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp marked this pull request as ready for review May 17, 2024 10:32
@alexwizp alexwizp requested a review from a team as a code owner May 17, 2024 10:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label May 19, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 19, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 869.3KB 869.4KB +147.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5405 +5405
total size - 8.8MB +8.8MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Keyboard tested.

@alexwizp alexwizp merged commit 53bdba3 into elastic:main May 20, 2024
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project Feature:SLO Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants