-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Obs SLOs][KEYBOARD]: Actions menu must be available in Card view on ::focus event #183652
Conversation
…w on ::focus event Closes: elastic/observability-dev#3390
/ci |
/ci |
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
💚 Build Succeeded
Metrics [docs]Async chunks
Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Keyboard tested.
Closes: https://github.com/elastic/observability-dev/issues/3390
Description
The Obs SLOs cards allow users to access a menu of actions on
::hover
but that menu is not available on::focus
. This has a workaround by switching to List or Compact view, but still represents a major keyboard usability issue and is going to be treated as a level one defect. Screenshot attached below.Steps to recreate
[ ... ]
menu appearsTab
key to navigate through the card by keyboard[ ... ]
menu never appearsWhat was changed?:
1 The hover functionality was updated in favor of CSS
Screen
Screen.Recording.2024-05-16.at.17.31.13.mov