Add index mode to esql index source #108747
Conversation
dnhatn
force-pushed
the
time-series-source
branch
5 times, most recently
from
3f2c588
to
c0561f0
Compare
dnhatn
added
:Analytics/ES|QL
dnhatn
force-pushed
the
time-series-source
branch
4 times, most recently
from
c5e4a1a
to
344426b
Compare
dnhatn
force-pushed
the
time-series-source
branch
from
344426b
to
ebe4d57
Compare
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
| if (in.getTransportVersion().onOrAfter(TransportVersions.ESQL_ADD_INDEX_MODE_TO_SOURCE)) { | ||
| int ord = in.readByte(); | ||
| return switch (ord) { | ||
| case 0 -> IndexMode.STANDARD; |
There was a problem hiding this comment.
Nit: make 0, 1 etc part of the enum and add checks to enforce they're distinct?
There was a problem hiding this comment.
I pushed b07cd89 to serialize the name of the index mode instead.
| } | ||
|
|
||
| public EsQueryExec( | ||
| Source source, | ||
| EsIndex index, | ||
| IndexMode indexMode, |
There was a problem hiding this comment.
Should the mode be part of EsIndex?
There was a problem hiding this comment.
Yeah, I've tried that before, but the problem is that this EsIndex is used in the QL module and many other places. Let me replicate it in ESQL and add the index mode to the new EsIndex.
There was a problem hiding this comment.
Hope #108773 will make things simpler.
There was a problem hiding this comment.
I gave this a try, but we create EsIndex inside IndexResolver, which depends on the field-caps responses rather than the command. I will revisit this again after we have index mode in field-caps.
| public EsqlUnresolvedRelation(Source source, TableIdentifier table, List<Attribute> metadataFields, String unresolvedMessage) { | ||
| private final IndexMode indexMode; | ||
|
|
||
| public EsqlUnresolvedRelation( |
There was a problem hiding this comment.
Consider providing two factory methods setting the mode, e.g. create() and createTsdb()
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/physical/EsQueryExec.java
Outdated
Show resolved
Hide resolved
...in/esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/LocalPhysicalPlanOptimizer.java
Outdated
Show resolved
Hide resolved
...e-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/TSDBRestEsqlIT.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public EsQueryExec( | ||
| Source source, | ||
| EsIndex index, | ||
| IndexMode indexMode, |
There was a problem hiding this comment.
Hope #108773 will make things simpler.
|
@martijnvg @kkrik-es @bpintea Thanks for reviewing. |
This PR adds index mode to the ESQL index source. Specifically, METRICS commands will now run with TimeSeriesSortedSourceOperatorFactory. Also, it removes the time-series pragmas in favor of METRICS commands.