Remove default pipelines from failure store indices #108742
Merged
+85
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data stream template
jbaiera
added
>non-issue
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
approved these changes
May 16, 2024
| @@ -410,7 +410,7 @@ private static ClusterState createBackingIndex( | |||
| public static ClusterState createFailureStoreIndex( | |||
| MetadataCreateIndexService metadataCreateIndexService, | |||
| String cause, | |||
| Settings settings, | |||
| Settings nodeSettings, | |||
There was a problem hiding this comment.
I've regretted not naming this nodeSettings ever since I added this, so I had this on my TODO for when I happened to touch it. Thanks for changing this :)
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure store indices inherit index settings from its parent data stream's template. When creating the failure store we should override the settings so that the data stream's default pipeline settings are not set on the failure store indices.