Add support for failure stores in ILM #108741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should maybe take a look at doing this more widespread to simplify the builder code when making modifications.
Tests are mostly set up to randomly switch operations between failure indices and backing indices. Most steps and actions will support failure stores without too much fuss. Main concerns are any actions where their successful operation is dependent on shard counts (like shrink/resize).
jbaiera
added
>non-issue
:Data Management/ILM+SLM
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
reviewed
May 20, 2024
There was a problem hiding this comment.
This is looking good! This doesn't also make failure stores use the ILM policy from their data stream, though, right? I'm assuming you'll do that in a follow-up PR?
I only have a couple of comments on the non-test code; I'll have a look at the test code later.
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataDeleteIndexService.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/DeleteStep.java
Outdated
Show resolved
Hide resolved
...n/core/src/main/java/org/elasticsearch/xpack/core/ilm/ReplaceDataStreamBackingIndexStep.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/RolloverStep.java
Show resolved
Hide resolved
…cture as the others.
…g the single backing write index. All other cases will get an error.
gmarouli
reviewed
May 22, 2024
...ore/src/test/java/org/elasticsearch/xpack/core/ilm/CheckNoDataStreamWriteIndexStepTests.java
Outdated
Show resolved
Hide resolved
gmarouli
reviewed
May 22, 2024
| assertThat(listenerCalled.get(), is(true)); | ||
| } | ||
|
|
||
| public void testDeleteWorksIfWriteIndexIsTheOnlyIndexInDataStream() throws Exception { |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
May 22, 2024
|
@elasticmachine update branch |
nielsbauman
approved these changes
May 23, 2024
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/DeleteStep.java
Outdated
Show resolved
Hide resolved
nielsbauman
reviewed
May 24, 2024
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/WaitForRolloverReadyStep.java
Outdated
Show resolved
Hide resolved
nielsbauman
approved these changes
May 24, 2024
|
@elasticmachine update branch |
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure stores on a data stream will inherit the ILM policy of the parent data stream by default. This PR adds logic to ensure failure stores are properly accounted for in data stream related ILM operations.