Use assertThatLogger where appropriate #108732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests use MockLogAppender to assert on a single expected logging message. The utility method assertThatLogger handles creating the appender and asserting the expecation. However some other tests want to do the same but with multiple expectations. This commit adjusts assertThatLogger to allow multiple expectations, and converts a few tests that had helper methods that are now obsoleted.
rjernst
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
v8.15.0
Team:Core/Infra
ldematte
approved these changes
May 17, 2024
parkertimmins
pushed a commit
to parkertimmins/elasticsearch
that referenced
this pull request
May 17, 2024
Some tests use MockLogAppender to assert on a single expected logging message. The utility method assertThatLogger handles creating the appender and asserting the expecation. However some other tests want to do the same but with multiple expectations. This commit adjusts assertThatLogger to allow multiple expectations, and converts a few tests that had helper methods that are now obsoleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests use MockLogAppender to assert on a single expected logging message. The utility method assertThatLogger handles creating the appender and asserting the expecation. However some other tests want to do the same but with multiple expectations. This commit adjusts assertThatLogger to allow multiple expectations, and converts a few tests that had helper methods that are now obsoleted.