Clean up role resolution with CrossClusterApiKeyRoleReference
#108707
+106
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>refactoring
:Security/Authorization
|
Pinging @elastic/es-security (Team:Security) |
|
@elasticmachine update branch |
jakelandis
approved these changes
Jun 3, 2024
| @@ -127,9 +120,46 @@ public BytesReference getRoleDescriptorsBytes() { | |||
| public ApiKeyRoleType getRoleType() { | |||
| return roleType; | |||
| } | |||
| } | |||
|
|
|||
| final class CrossClusterApiKeyRoleReference implements RoleReference { | |||
There was a problem hiding this comment.
nit: can add some javadoc to this , especially to disambiguate this from CrossClusterAccessRoleReference
nit*2: just a style thing...but I generally have a preference towards more top level classes and fewer nested classes. IMO it results in simpler readability and combined with Javadoc leads to less assumptions about what it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles role resolution for cross-cluster API key role references. Previously, these were handled as generic API key role references but the flows are now different enough to use a new, standalone class instead.
Relates: #108600