Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jupyter notebook for Geospatial Blog #231

Merged
merged 38 commits into from
May 29, 2024

Conversation

philippkahr
Copy link
Contributor

Hi,

this should add the geospatial Jupyter Notebook for the accompanying blog post.

@joemcelroy
Copy link
Member

Hi there,

Theres an issue rendering the notebook (https://github.com/elastic/elasticsearch-labs/blob/c9d54687840cac94f94dffa5ac4e4e76a9c7f2ce/notebooks/search/09-geospatial-search.ipynb) - looks like you have images in the notebook that doesn't exist.

Also as this is for content for blog, could you add it in the supporting-blog-content folder instead please?

maxjakob and others added 18 commits May 8, 2024 10:56
* Tokenization notebook: fix step_size calculation

* Update notebooks/document-chunking/tokenization.ipynb

Co-authored-by: Miguel Grinberg <miguel.grinberg@elastic.co>

---------

Co-authored-by: Miguel Grinberg <miguel.grinberg@elastic.co>
* adding first pass at notebook for blog

* added link to blog

* added new line and eof

* ran pre-commit
…#232)

* notebooks for ingestion suitable for playground

* update copy

* update formatting

* updates

* Update notebooks/ingestion-and-chunking/website-chunking-ingest.ipynb

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

* updates

* update teardown script

* update test file

* updates to see if passes

* remove pypdf dep

* updates

---------

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: Marci Windsheimer <333176+marciw@users.noreply.github.com>
* Splitter notebook: extend new strategy class

fixes elastic#240

* remove variable
* updating example

* renaming based on feedback from Miguel

* renaming based on feedback from Miguel
* Add per-version testing restrictions

* updated testing documentation

* replace eland pin on 8.12 with an exemption list
* added notebook

* formatted ingest pipeline

* made single search variable

* made single search variable

* using inference id in query vector builder

* added notes
Copy link

@carlyrichmond carlyrichmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one minor typo but aside from that it's looking good.

@carlyrichmond
Copy link

@philippkahr I think you've got a formatting issue still on the notebook as it's still not building:

:11: SyntaxWarning: invalid escape sequence '.'
:11: SyntaxWarning: invalid escape sequence '.'
:11: SyntaxWarning: invalid escape sequence '.'
error: cannot format supporting-blog-content/geospatial-llm/09-geospatial-search.ipynb: Cannot parse: 37:46: print(f"Distance between AirBnB and {hit["_source"]["name"]}: {hit["sort"][0]} km")

@philippkahr philippkahr merged commit 570f8dc into elastic:main May 29, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet