Add permission checks to all install and upgrade integration tests #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
One of the issues here is that the Elastic Agent user was renamed from |
cmacknz
reviewed
May 16, 2024
cmacknz
approved these changes
May 16, 2024
blakerouse
force-pushed
the
testing-install-perms
branch
from
32f0120
to
403f33b
Compare
|
mergify bot
pushed a commit
that referenced
this pull request
May 20, 2024
…4761) * Fix calling enroll from install. * Refactor installation checks. * Add detailed checks. * Improve permission validation. * Fix lint. * Fix windows lint. * More lint. * Adjustments for <=8.13. * Pass context into CheckSuccess. * Fix upgradetest to only check installation for specific versions. * Inverse logic. (cherry picked from commit 07f7921)
Merged
4 tasks
blakerouse
added a commit
that referenced
this pull request
May 20, 2024
…4761) (#4778) * Fix calling enroll from install. * Refactor installation checks. * Add detailed checks. * Improve permission validation. * Fix lint. * Fix windows lint. * More lint. * Adjustments for <=8.13. * Pass context into CheckSuccess. * Fix upgradetest to only check installation for specific versions. * Inverse logic. (cherry picked from commit 07f7921) Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the integration install and upgrade tests for both Linux and Windows to ensure that the permissions set during installation and installation + enrollment are correct.
Why is it important?
Ensures that any future changes that can cause bad permissions are caught during the PR stage.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog tool