Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Confluence] Update logs #2526

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Confluence] Update logs #2526

wants to merge 4 commits into from

Conversation

moxarth-elastic
Copy link
Collaborator

@moxarth-elastic moxarth-elastic commented May 8, 2024

Part Of #2299

Adds a data source validation and update existing logs.

Log file: https://drive.google.com/file/d/1NmTwME31dcvFzVRMhUCrjQaWAF93CfM6/view?usp=drive_link

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

@moxarth-elastic moxarth-elastic mentioned this pull request May 8, 2024
6 tasks
Copy link
Member

@jedrazb jedrazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, when handling client errors in _handle_client_errors

  • can we log url that is causing 500
  • when handling other errors (else raise at the end) can we log as error full exception and url

@jedrazb
Copy link
Member

jedrazb commented May 10, 2024

in api_call the ServerDisconnectedError should be probably logged as well (as we are closing the session and re-raising)

Copy link
Member

@artem-shelkovnikov artem-shelkovnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. "Started pagination for the API endpoint: rest/api/search?cql={query} to host: https://jira-connector.atlassian.net/wiki" should be DEBUG. Also query is not actually shown
  2. Sync should report progress while in INFO. Now I see nothing - can we log what entities are fetched in INFO?
  3. Paginated calls report only the first call, can you make sure every page call generates a log line?

@artem-shelkovnikov
Copy link
Member

@moxarth-elastic can you share updated log lines in DEBUG for all the log issues when you finish addressing comments?

@moxarth-elastic
Copy link
Collaborator Author

moxarth-elastic commented May 14, 2024

@moxarth-elastic can you share updated log lines in DEBUG for all the log issues when you finish addressing comments?

Here is the updated log file: https://drive.google.com/file/d/1NmTwME31dcvFzVRMhUCrjQaWAF93CfM6/view?usp=drive_link. Updated the same in the description

@artem-shelkovnikov
Copy link
Member

Looks better, a couple more:

  • "Successfully connected to Confluence" should be DEBUG when called from ping method, it's great to have it when you call it from get_docs though. Failure to connect should be WARN
  • "Started pagination for the API endpoint: rest/api/search?cql={query} to host: https://jira-connector.atlassian.net/wiki" - notice {query} is not inlined. Can we also use generic message here, like you did for GET call? Also this line should not be info.

@moxarth-elastic
Copy link
Collaborator Author

buildkite test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants