-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Confluence] Update logs #2526
base: main
Are you sure you want to change the base?
[Confluence] Update logs #2526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, when handling client errors in _handle_client_errors
- can we log url that is causing
500
- when handling other errors (else raise at the end) can we log as error full
exception
andurl
in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "Started pagination for the API endpoint: rest/api/search?cql={query} to host: https://jira-connector.atlassian.net/wiki" should be DEBUG. Also query is not actually shown
- Sync should report progress while in INFO. Now I see nothing - can we log what entities are fetched in INFO?
- Paginated calls report only the first call, can you make sure every page call generates a log line?
@moxarth-elastic can you share updated log lines in DEBUG for all the log issues when you finish addressing comments? |
Here is the updated log file: https://drive.google.com/file/d/1NmTwME31dcvFzVRMhUCrjQaWAF93CfM6/view?usp=drive_link. Updated the same in the description |
Looks better, a couple more:
|
buildkite test this |
Part Of #2299
Adds a data source validation and update existing logs.
Log file: https://drive.google.com/file/d/1NmTwME31dcvFzVRMhUCrjQaWAF93CfM6/view?usp=drive_link
Checklists
Pre-Review Checklist
config.yml.example
)v7.13.2
,v7.14.0
,v8.0.0
)