Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anghelnicolae/sharepoint server advanced #2475

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Anghelnicolae/sharepoint server advanced #2475

wants to merge 7 commits into from

Conversation

artem-shelkovnikov
Copy link
Member

Closes https://github.com/elastic/connectors-py/issues/###

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference
  • if you added or changed Rich Configurable Fields for a Native Connector, you made a corresponding PR in Kibana

Changes Requiring Extra Attention

  • Security-related changes (encryption, TLS, SSRF, etc)
  • New external service dependencies added.

Related Pull Requests

Release Note

anghelnicolae and others added 6 commits April 4, 2024 14:54
@anghelnicolae
Made Site collections required to contain the entire URL so that the …
a5f19e2 
…connector supports Host Named Site Collections.

Added support for NTLM by switching from aiohttp to httpx.
@anghelnicolae
Removed asyncio from imports
af1180e
@anghelnicolae
Fixed item URLs
82ea3bb 
Added option to select between Basic and NTLM authentication
Other changes suggested by the Elasticsearch team
@anghelnicolae
Ran linter. Fixed attachment urls. Fixed tests.
922d8a4
@anghelnicolae
Fixed linting. Added authentication configuration to connector.json.
705c874
@artem-shelkovnikov
Update fixture for ftest
ac7510e
@artem-shelkovnikov artem-shelkovnikov mentioned this pull request May 1, 2024
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-backport v8.15.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@artem-shelkovnikov @anghelnicolae