-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool for generating schema type annotations #7186
Open
aljazerzen
wants to merge
11
commits into
master
Choose a base branch
from
schema-type-annotations
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljazerzen
changed the title
schema type annotations
Tool for generating schema type annotations
Apr 12, 2024
The verdict here is:
|
aljazerzen
force-pushed
the
schema-type-annotations
branch
from
April 30, 2024 10:20
133c311
to
a1ca831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our schema classes have generated getter methods for each of the fields:
This PR adds a tool that generates
.pyi
files inedb/schema/
, which contain definitions for all of these generated getters.We do have mypy extension that already picks-up these getters, even without
.pyi
definitions.Regardless, this
.pyi
approach is useful because language servers (PyLance) cannot use mypy extension. Now, "go to definition", "show usages" and other code actions work.There is a few drawbacks:
get_subjectexpr
returnsExpression
, but it will infer type ofsubjexpr
to beAny
. What?Because of these drawbacks, #7166 is still useful.