Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cross-env dependency to examples/playwright #13634

Merged
merged 1 commit into from
May 29, 2024

Conversation

xai
Copy link
Contributor

@xai xai commented Apr 23, 2024

What it does

This adds cross-env as dev dependency and adjusts the scripts in examples/playwright accordingly. This is a way to enable running the playwright tests on Windows machines.

Contributed on behalf of STMicroelectronics

How to test

  1. Clone Theia on a Windows machine and checkout this branch
  2. Build browser and electron examples
  3. Build the playwright tests: cd examples/playwright; yarn; yarn build
  4. Run the browser tests: yarn ui-tests

Follow-ups

We checked the status of the cross-env package and found that it is in maintenance mode. The authors of cross-env consider the development finished and fix only severe bugs and keep it up-to-date along with nodejs. The most recent commit in cross-env is 4 years old.

Please consider this and the implied additional threats regarding supply chain attacks that adding cross-env as a dev dependency might introduce into Theia when reviewing this PR.

Review checklist

Reminder for reviewers

@planger
Copy link
Contributor

planger commented May 2, 2024

#12405 is related and possibly already fixed and enabled by this PR.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me on Windows 👍

Note that I get testing failures on Windows, but the tests run, which is the goal of this PR.

This allows running the Playwright tests in Windows.

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
@planger planger merged commit 7788a58 into eclipse-theia:master May 29, 2024
14 checks passed
@planger planger deleted the playwright-windows branch May 29, 2024 09:58
@planger planger added this to the 1.50.0 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants