This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
using mapfile instead of read ( require v4 bash ) #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, first off this seems like a really awesome project 馃檪 I love me some bash 馃榿. So, thank you for making this. One of my friends linked to it for something they were doing 馃檪
Maybe there is another reason that you didn't use mapfile before, but since you are requiring v4+ anyways ( and mapfile was released in v4). Then I think this is a slightly less complex version of the same command. Maybe you were trying to be a bit more explicit for visual understanding of how things get split up ( setting IFS and everything ), but I get the same output when I run those example commands.
Let me know if there is anything I can do to help 馃檪 or if there is anything else I need to add ( tests, etc... ).
I look forward to looking more into this pure bash bible 馃榿