Allow secure cookies #279
Open
Allow secure cookies #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are serving over HTTPS this addresses #250 |
|
why reformat all the files lol |
|
I just ran So they'd match the go standard. I did do it as a separate commit to make the changes easier to see. Most IDEs will auto run |
|
I just wanted to quickly view the new changes you made. I guess I didn't read the part where you said it was a separate commit, could've just opened that commit up, my bad lol. I wouldn't touch any external code unrelated to the PR, but I'm not the maintainer nor necessarily represent their views. It's just a light nitpick, don't feel like you must make changes to your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stripping the secure flag, it breaks cookies with
SameSite=None. This PR will add an option for users to disable the default stripping of secure cookies.It also contains a
.gitignoreandgo fmtin a separate commits, to make it easier to see what i really changed.