Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: $with for withReplicas #1839

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

malonehedges
Copy link

@malonehedges malonehedges commented Jan 27, 2024

$with wasn't being copied over and was undefined

resolves #1834

@AndriiSherman AndriiSherman changed the base branch from main to beta March 9, 2024 16:15
@hirbod
Copy link

hirbod commented May 27, 2024

@worm-emoji @AndriiSherman is there any chance to get this merged? This has been broken for us for many months already and we have to re-apply our patch on every update.

@worm-emoji
Copy link

it's not that big of a deal if it gets merged or not. life is short

@hirbod
Copy link

hirbod commented May 27, 2024

Wow, what a totally normal and totally sane response from an OSS maintainer. Definitely not weird at all, like, at all.
patch-package to the rescue, I guess.

EDIT: just figured you're not even a maintainer of this package, got confused by your review stamp.

@worm-emoji
Copy link

yeah, not a contributor. just approved because i liked the pr. and i responded because you tagged me.

but i hope you can use this moment to touch grass and calm down. maybe go on a long walk or spend some time with family.

i've been in your position before: the PR won't make you happy, i promise. i would just try to forget about it and move on.

@hirbod
Copy link

hirbod commented May 27, 2024

I am quite calm, thank you very much. You're correct, this PR does not make me happy. However, every patch I am able to remove and do not have to re-apply with every upgrade saves me time. In my opinion, pinging after 5 months is fair enough. Let's end this convo here. Sorry for tagging you wrongfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: $with is undefined on withReplicas
4 participants