Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui)!: add support for hiding context menu #2275

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented May 18, 2024

BREAKING CHANGE: The default values for header and footer are now set to true.

BREAKING CHANGE: The default values for `header` and `footer` are now set to true.
@jikkai jikkai requested review from Jocs and wzhudev as code owners May 18, 2024 17:26
Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 30.85%. Comparing base (4e7b4c5) to head (01b1918).

Files Patch % Lines
packages/ui/src/views/App.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2275      +/-   ##
==========================================
- Coverage   30.85%   30.85%   -0.01%     
==========================================
  Files        1380     1380              
  Lines       70919    70922       +3     
  Branches    14905    14909       +4     
==========================================
- Hits        21884    21883       -1     
- Misses      49035    49039       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 18, 2024

View Deployment

#9144115378

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jikkai jikkai merged commit 3f12ad8 into dev May 20, 2024
9 checks passed
@jikkai jikkai deleted the feat/context-menu branch May 20, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants