Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drawing): image feature and drawing architecture #2272

Closed
wants to merge 69 commits into from

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented May 18, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@DR-Univer DR-Univer added this to the Feature Milestone II milestone May 18, 2024
@DR-Univer DR-Univer assigned DR-Univer and unassigned DR-Univer May 18, 2024
@DR-Univer DR-Univer marked this pull request as ready for review May 21, 2024 04:56
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 3.87282% with 4021 lines in your changes are missing coverage. Please review.

Project coverage is 28.93%. Comparing base (41d0639) to head (7515253).

Files Patch % Lines
packages/engine-render/src/scene.transformer.ts 0.00% 575 Missing ⚠️
...ers/sheet-drawing-transform-affected.controller.ts 0.00% 403 Missing ⚠️
...ng-ui/src/controllers/drawing-update.controller.ts 0.00% 392 Missing ⚠️
...es/drawing/src/services/drawing-manager.service.ts 0.00% 379 Missing ⚠️
...ing-ui/src/controllers/image-cropper.controller.ts 0.00% 232 Missing ⚠️
...wing-ui/src/controllers/image-update.controller.ts 0.00% 178 Missing ⚠️
packages/engine-render/src/shape/image.ts 0.00% 139 Missing ⚠️
...src/controllers/sheet-drawing-update.controller.ts 0.00% 124 Missing ⚠️
.../drawing-ui/src/views/crop/image-cropper-object.ts 0.00% 123 Missing ⚠️
...es/drawing-ui/src/views/panel/DrawingTransform.tsx 0.00% 114 Missing ⚠️
... and 96 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2272      +/-   ##
==========================================
- Coverage   30.16%   28.93%   -1.23%     
==========================================
  Files        1417     1479      +62     
  Lines       72589    76140    +3551     
  Branches    15208    15893     +685     
==========================================
+ Hits        21893    22030     +137     
- Misses      50696    54110    +3414     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@DR-Univer DR-Univer closed this May 25, 2024
@DR-Univer DR-Univer deleted the feat/drawing-2 branch May 25, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants