Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker build and push to container registry #51

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

joao-zanutto
Copy link

@joao-zanutto joao-zanutto commented Apr 15, 2024

Adds GitHub Actions workflow that builds and push a docker image to ghcr.io container registry.

  • workflow is triggered on a new tag being pushed in the repository
  • image is tagged with two tags: :versionTag and :latest

Requires initial setup of GitHub Container Registry or Dockerhub from repository mainteners

closes #11

Copy link

vercel bot commented Apr 15, 2024

@joao-zanutto is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@joao-zanutto
Copy link
Author

Initial commit was made with a personal Dockerhub repository for testing purposes, but it considers ghcr.io as target registry, however it can also be changed to support Dockerhub instead (can also support both registries in parallel).

I can assist on the initial registry setup for ghcr.io/Dockerhub, just let me know if assistance is needed

Copy link
Author

@joao-zanutto joao-zanutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values used for initial testing that will be changed before merging

.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
@joao-zanutto
Copy link
Author

Image built and tested with act and available on test repo in Dockerhub

Run it with docker run -p 8080:80 jpberno/test-deawdb:latest and then go to http://localhost:8080/ to check it's working.

I'll be updating the workflow to remove testing credentials, trigger and registry

@DenuxPlays
Copy link

DenuxPlays commented Apr 17, 2024

Arm support would be great.

.github/workflows/docker.yml Outdated Show resolved Hide resolved
Co-authored-by: Timon Klinkert <83671398+DenuxPlays@users.noreply.github.com>
Copy link

@DenuxPlays DenuxPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Docker image
2 participants