Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure i18n and add simplified Chinese (#99) #110

Merged
merged 11 commits into from
May 17, 2024
Merged

Configure i18n and add simplified Chinese (#99) #110

merged 11 commits into from
May 17, 2024

Conversation

1ilit
Copy link
Member

@1ilit 1ilit commented May 16, 2024

Hello! I would really appreciate if someone fluent in Chinese could review the automated translations in '/src/i18n/locales/zh.js'

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 0:50am

@1ilit 1ilit added the help wanted Extra attention is needed label May 16, 2024
@felixsmli
Copy link

They look mostly fine, except these may be ambiguous:

import_from_source: "从源导入"
export_source: "导出源"

More explicit translation would be:
import_from_source: "导入源代码"
export_source: "导出为源代码"

Actually I think the original English text is a little bit ambiguous. It's not clear what "source" is on a first look. Personally I would prefer "Import from SQL" and "Export as SQL", thus "导入 SQL 源代码" and "导出为 SQL 源代码"

@Jackxwb
Copy link

Jackxwb commented May 16, 2024

I believe the following translation may be superior

duplicate_table_by_name: "重复声明了名为 '{{tableName}}' 的表",
duplicate_fields:
      "在表 '{{tableName}}' 中重复声明了名为 '{{fieldName}}' 的字段",
duplicate_index:
      "在表 '{{tableName}}' 中重复声明了名为 '{{indexName}}' 的索引",
duplicate_types: "重复声明了名为 '{{typeName}}' 的类型",
duplicate_type_fields:
      "在自定义类 '{{typeName}}' 中重复声明了名为 '{{fieldName}}' 的字段",
duplicate_reference: "重复声明了名为 '{{refName}}' 的引用",

I suspect there may be errors in the translation below

cardinality: "基数",
show_cardinality: "显示基数",

In the Chinese context, "基数" typically refers to mathematics. However, if referring to the relationship between two fields in a database, the term "关系映射" can be used.
cardinality: "关系映射"
show_cardinality: "显示关系", or show_cardinality: "显示关系映射",

import: "导入",
file: "文件",
new: "新建",
new_window: "新窗口",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more accurate description of the feature "New Window" is "在新标签中打开" meaning to open it in a new browser tab.

exit: "退出",
edit: "编辑",
undo: "撤销",
redo: "重做",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"redo" is translated as "恢复" in vscode

image.

cut: "剪切",
copy: "复制",
paste: "粘贴",
duplicate: "复制",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more accurate description of the feature "Duplicate is "克隆" meaning to clone

Because when we use the Duplicate, it directly clones a selectedElement.

paste: "粘贴",
duplicate: "复制",
delete: "删除",
copy_as_image: "复制为图像",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more accurate description of the feature "Copy As Image" is "复制画布为图片" meaning to copy the canvas as an image.

delete: "删除",
copy_as_image: "复制为图像",
view: "视图",
header: "标题",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"header" translated as "菜单栏" might be more appropriate.

This component is translated as "菜单栏" in VSCode, but they write its English name as "menuBar".

language: "语言",
flush_storage: "清除存储",
are_you_sure_flush_storage:
"确定要清除存储吗?这将不可逆地删除所有您的图表和自定义模板。",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"确定要清除存储吗?这将不可逆地删除所有您的图表和自定义模板。",
"您确定要清除存储吗?此操作将无法恢复地删除您所有的图表和自定义模板。",

flush_storage: "清除存储",
are_you_sure_flush_storage:
"确定要清除存储吗?这将不可逆地删除所有您的图表和自定义模板。",
storage_flushed: "存储已清除",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
storage_flushed: "存储已清除",
storage_flushed: "存储已清空",

storage_flushed: "存储已清除",
help: "帮助",
shortcuts: "快捷键",
ask_on_discord: "在 Discord 上问我们",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ask_on_discord: "在 Discord 上问我们",
ask_on_discord: "在 Discord 联系我们",

notes: "注释",
types: "类型",
search: "搜索...",
no_tables: "没有表",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
no_tables: "没有表",
no_tables: "空空如也",

"空空如也" is an idiom meaning completely empty, devoid of anything.

You can change the empty prompts for "relationship," "area," "notes," etc. to this.

primary: "主键",
unique: "唯一",
autoincrement: "自增",
default_value: "默认",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default_value: "默认",
default_value: "默认值",

Copy link

@photowey photowey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small comments to the translation.

are_you_sure_delete_diagram: "确定要删除此图表吗?此操作不可逆转。",
oops_smth_went_wrong: "糟糕!出了些问题。",
import_diagram: "导入图表",
import_from_source: "从源导入",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import_from_source: "从源文件导入",

import_diagram: "导入图表",
import_from_source: "从源导入",
export_as: "导出为",
export_source: "导出源",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export_source: "导出为源文件",

import: "导入",
file: "文件",
new: "新建",
new_window: "新窗口",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new_window: "新建窗口",

@1ilit
Copy link
Member Author

1ilit commented May 16, 2024

Thank you everyone!

@1ilit 1ilit merged commit 002e240 into main May 17, 2024
4 checks passed
@1ilit 1ilit deleted the i18n branch May 17, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants