Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(god): fix cursor color #7841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darth10
Copy link
Contributor

@darth10 darth10 commented Apr 21, 2024

This was broken in aa079b0 (#7049).

When the cursor changes from color A to color B, it doesn't ever change back to color A, as (face 'cursor) will now return color B.
Since the default cursor in the Doom theme uses the highlight background color, we can use that when setting the cursor color when this module is enabled.

Screenshots

For example, when the :editor god module is enabled, change the cursor color by moving to the end of a long line, and then move to the beginning of the line so that the default cursor color should be shown.

Before

image

After

image


  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.
  • I am blindly checking these off.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

This was broken in aa079b0.

Since the default cursor in the Doom theme uses the `highlight` color,
we can use that when setting the cursor color when this module is
enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant