Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gdscript): replace removed functions with new binding #7831

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

bpseudopod
Copy link
Contributor

This commit removes the keybinds to add and remove a breakpoint in a gdscript buffer, which were removed from gdscript-mode long ago, and replaces them with one binding to toggle a breakpoint.

Fix: #7254


  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to the git conventions.
  • I am blindly checking these off.
  • Any relevant issues or PRs have been linked to.

This commit removes the keybinds to add and remove a breakpoint in a
gdscript buffer, which were removed from gdscript-mode long ago, and
replaces them with one binding to toggle a breakpoint.
@hlissner hlissner added is:update An effort to catch up with changes made elsewhere module:lang/gdscript Pertains to Doom's :lang gdscript module labels Apr 18, 2024
@hlissner hlissner added this to the modules v24.05 milestone Apr 18, 2024
@hlissner hlissner merged commit c625b78 into doomemacs:master Jun 3, 2024
@hlissner
Copy link
Member

hlissner commented Jun 3, 2024

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:update An effort to catch up with changes made elsewhere module:lang/gdscript Pertains to Doom's :lang gdscript module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several leader key bindings in :lang gdscript no longer exist
2 participants