Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ophints): add goggles for non-evil users #7810

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Dev380
Copy link
Contributor

@Dev380 Dev380 commented Apr 11, 2024

This adds the goggles package as a module flag
to use goggles instead of volatile-highlights-mode as a non-evil user.


This adds the goggles package as a module flag
to use goggles instead of volatile-highlights-mode
as a non-evil user.
@hlissner hlissner added is:feature Adds or requests new features, or extends existing ones module:ui/ophints Pertains to Doom's :ui ophints module labels Apr 12, 2024
Copy link
Member

@hlissner hlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any compelling reason to keep volatile-highlights? If not, I'd rather do away with it entirely.

@Dev380
Copy link
Contributor Author

Dev380 commented Apr 12, 2024

I'm not sure how the release schedule works so I kept it in to avoid a breaking change; should vhl be removed and goggles.el be the new default when evil is off?

@Dev380 Dev380 requested a review from hlissner April 12, 2024 12:26
@Dev380
Copy link
Contributor Author

Dev380 commented Apr 12, 2024

VHL is removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature Adds or requests new features, or extends existing ones module:ui/ophints Pertains to Doom's :ui ophints module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants